Use correct byte size for truncation #810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating payload length for truncation,
payload.length
was being used. This returns the character count (or more accurately the UTF-16 code point count), rather than the UTF-8 byte count. This leads to non-ascii payloads being insufficiently truncated and then rejected by the API.This PR uses a minimal implementation for counting UTF-8 bytes that never undercounts bytes, and rarely overcounts*. This is safe and valid to be used for truncation, and is significantly smaller and faster than a complete UTF-8 encoder.