Enable onSendCallback and transform callback for react-native #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me |
waltjones
changed the title
1 task
mudetroit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Enable onSendCallback and transform callabck for react-native
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References rollbar/rollbar-react-native#109
This PR enables
onSendCallbackandtransformfor the react-native target when set in the configuration.This PR also updates the react-native target to used the shared implementation of the predicates (checkIgnore, checkLevel) which include the support for
onSendCallback. The react-native specific implementation for these was added before the shared predicates existed. When shared predicates were added, the react-native implementation didn't get removed.2nd commit addresses a change in behavior in Travis' headless chrome.