Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic improvements #850

Merged
merged 1 commit into from
May 12, 2020
Merged

Diagnostic improvements #850

merged 1 commit into from
May 12, 2020

Conversation

waltjones
Copy link
Contributor

@waltjones waltjones commented May 8, 2020

Add a few things to the notifier.diagnostic key in the payload.

  • is_uncaught
  • Callback functions from config, if present (transform, onSendCallback, checkIgnore)
  • Caller's type signature for Rollbar.log()

Payload keys are snake_case, except option keys within configured_options which retain their original javascript case.

Copy link
Contributor

@austenLacy austenLacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waltjones Looks good. Just 1 small question/comment.

src/transforms.js Show resolved Hide resolved
@austenLacy
Copy link
Contributor

@waltjones do we need to update any of the Typescript types for these changes?

@waltjones
Copy link
Contributor Author

Currently we don't have TypeScript definitions for the payload data structure.

@waltjones waltjones merged commit 029e67d into master May 12, 2020
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants