Skip to content

Commit

Permalink
Add test for graphite.parse_metric when exception is raised
Browse files Browse the repository at this point in the history
Add test for when the API call to Graphite throws an exception.
  • Loading branch information
JeanFred committed Oct 17, 2017
1 parent bc58675 commit af66cc8
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions cabot/cabotapp/tests/tests_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,19 @@ def test_graphite_run(self):
result = checkresults.order_by('-time')[0]
self.assertEqual(result.error, u'PROD: 9.16092 > 9.0')

@patch('cabot.cabotapp.graphite.requests.get')
def test_graphite_series_run_exception(self, fake_graphite_series_response):
fake_graphite_series_response.side_effect = requests.exceptions.RequestException("some error")
jsn = parse_metric('fake.pattern', utcnow=1387818601)
expected = {
'series': [],
'raw': 'Error getting data from Graphite: some error',
'num_series_with_data': 0,
'error': 'Error getting data from Graphite: some error',
'num_series_no_data': 0
}
self.assertEqual(jsn, expected)

@patch('cabot.cabotapp.graphite.requests.get', fake_graphite_series_response)
def test_graphite_series_run(self):
jsn = parse_metric('fake.pattern', utcnow=1387818601)
Expand Down

0 comments on commit af66cc8

Please sign in to comment.