Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor Python 3 support #36

Closed
dekoza opened this issue Oct 1, 2016 · 5 comments · Fixed by #38
Closed

Poor Python 3 support #36

dekoza opened this issue Oct 1, 2016 · 5 comments · Fixed by #38
Labels
Python3

Comments

@dekoza
Copy link
Contributor

dekoza commented Oct 1, 2016

The tests are passing for Py3 although when I run trezor-gpg agent I get this:

Traceback (most recent call last):
  File "/home/minder/.virtualenvs/trezor/bin/trezor-gpg", line 11, in <module>
    load_entry_point('trezor-agent==0.7.0', 'console_scripts', 'trezor-gpg')()
  File "/home/minder/.virtualenvs/trezor/lib/python3.5/site-packages/trezor_agent/gpg/__main__.py", line 95, in main
    args.run(args)
  File "/home/minder/.virtualenvs/trezor/lib/python3.5/site-packages/trezor_agent/gpg/__main__.py", line 65, in run_agent
    sock_path = keyring.get_agent_sock_path()
  File "/home/minder/.virtualenvs/trezor/lib/python3.5/site-packages/trezor_agent/gpg/keyring.py", line 18, in get_agent_sock_path
    lines = sp.check_output(['gpgconf', '--list-dirs']).strip().split('\n')
TypeError: a bytes-like object is required, not 'str'

Nevertheless I'm working on a solution 😄
@dekoza
Copy link
Contributor Author

dekoza commented Oct 1, 2016

keepkeylib is not Py3 compatible 😞

@romanz
Copy link
Owner

romanz commented Oct 1, 2016 •
edited
Loading

Thanks for reporting this issue and the fixes :)

FTR, the KeepKey's issue is here: keepkey/python-keepkey#3 (comment)

@dekoza
Copy link
Contributor Author

dekoza commented Oct 1, 2016

I know. I'm wondering if we could switch keepkey for python-trezor.trezorlib - it looks like they fixed the Py3 issues there as It Works For Me™ 😉

I'll investigate and post appropriate patch in case of success.

@dekoza
Copy link
Contributor Author

dekoza commented Oct 1, 2016

Wait a minute... 😛 trezorlib is being used 😆 Silly me.

dekoza added a commit to Solution4Future/trezor-agent that referenced this issue Oct 1, 2016
@dekoza
better handling of keepkey dependency; fixes romanz#36
cf27b34
@dekoza dekoza mentioned this issue Oct 1, 2016
Merged
@romanz romanz closed this as completed in #38 Oct 4, 2016
@romanz
Copy link
Owner

romanz commented Oct 17, 2016

Now GPG feature should also work on Python 3: 65d2c04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Python3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

better handling of keepkey dependency Solution4Future/trezor-agent
2 participants
@romanz @dekoza