Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better handling of keepkey dependency #38

Merged
merged 3 commits into from
Oct 4, 2016
Merged

better handling of keepkey dependency #38

merged 3 commits into from
Oct 4, 2016

Conversation

dekoza
Copy link
Contributor

@dekoza dekoza commented Oct 1, 2016

fixes #36

@dekoza
Copy link
Contributor Author

dekoza commented Oct 1, 2016

Whoops, need to fix according to tests, sorry.

@dekoza
don't stop polling for more devices as having more than one inserted …
7d2c649 
…raises more problems and we need to keep the check
@dekoza
Copy link
Contributor Author

dekoza commented Oct 1, 2016

Right now the agent runs on Python3 using trezorlib only. Keepkey is Py2-only. We probably should warn user about this.

@dekoza
Copy link
Contributor Author

dekoza commented Oct 1, 2016

Hold that, I'm getting more errors. We need to make more integration tests.

@romanz
Copy link
Owner

romanz commented Oct 1, 2016

Many thanks for the contributions :)
Really appreciate it!

@romanz romanz merged commit 7d2c649 into romanz:master Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poor Python 3 support
2 participants
@dekoza @romanz