-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android 12 support #8
Conversation
Hi @zigapovhe , do you test in previous version for instance 9 , 10, 11? |
I didn't even properly test it for Android 12, that's why I've sent you an email. Not sure if you understand me correctly. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't build the project, Does it necessary to update kotlin & compileSdkVersion versions?
@@ -1,12 +1,12 @@ | |||
|
|||
buildscript { | |||
ext.kotlin_version = '1.5.0' | |||
ext.kotlin_version = '1.6.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't build the project, Does it necessary to update kotlin & compileSdkVersion versions?
@zigapovhe please indicate your distribution Version:
|
@zigapovhe I dont have a Android 12 and the changes does not work on Android 10. Thus I will crate a release branch with your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the grounds the PR is only for Android 12 devices, thus it works correctly
Thanks very much @zigapovhe |
Added support for Android12. Fixes issue #7