Feature/audit supplier #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,3 +35,7 @@ waytostay: | |||
| client_id: test_id | |||
| client_secret: test_secret | |||
|
|
|||
| audit: | |||
| secret_key: <%= ENV.fetch('AUDIT_SECRET_KEY', 'test_secret') %> | |||
| host: http://localhost:9292 | |||
There was a problem hiding this comment.
We don't actually hit the servers on test, do we?
There was a problem hiding this comment.
Nope, but the full YAML is here to put things through its paces
- connection_timeout - invalid_json - wrong_json
…sts) Return proper 404 response when 404
which returns an array of "fixtures/audit/property.json" with "identifier" being set to success, connection_timeout, etc ...
Otherwise, "base_currency = self.to_currency(base_currency)" becomes nil
Update PropertySynchronisation usage based on e1a33dd
choonkeat
force-pushed
the
feature/audit_supplier
branch
from
18ffd3d
to
f142eed
Compare
|
Rebased with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersede #123
Audit supplier server is a rack app serving static jsons from
spec/fixtures/auditWhen request param
property_id(quote, book) orreservation_number(cancel) is an error likeconnection_timeout, the rack server will respond accordingly to simulate the error. i.e. requests for a specific property or reservation will always get the same response.Sync workers will hit a
/spec/fixtures/audit/properties.jsonurl, which serves a list of properties withproperty_idvalues fromsuccess,connection_timeout, ...When consumers search and book, certain Audit properties (e.g.
property_id: success) will always succeed; and certain Audit properties (depending onproperty_id) will always hit the same error.When consumer try to cancel the booking, depending on the
reference_number, the cancellation will always succeed or encounter an error