make protect math exit early for money #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelle
reviewed
Oct 11, 2024
| @@ -1,6 +1,6 @@ | |||
| Package: tinkr | |||
| Title: Cast '(R)Markdown' Files to 'XML' and Back Again | |||
| Version: 0.2.0.9000 | |||
There was a problem hiding this comment.
I still think you might enjoy {fledge} since you're so good at incrementing version numbers!
| @@ -38,6 +38,8 @@ | |||
| #96, fix: #111, @zkamvar) | |||
| * Documents with no trailing newline will no longer throw a warning (issue: #65; | |||
| fix: #114, @zkamvar) | |||
| * Documents with dollar signs but no math will no longer fail with the | |||
There was a problem hiding this comment.
Hey I really like your tracking both issue and fix!
| @@ -1,3 +1,12 @@ | |||
| test_that("(#121) single dollar lines dont throw errors", { | |||
| expected <- "I've only got $2 in the bank. Feels bad, man.\n" | |||
There was a problem hiding this comment.
could you add the same example to the README? saying that you can use dollars as currency without any problem?
There was a problem hiding this comment.
I've added it, but I've added a caveat that there will be a problem if there is a mix.
|
This is great! Thanks @zkamvar ! 🙏 |
maelle
approved these changes
Oct 14, 2024
| @@ -28,3 +28,22 @@ you must be sure to either use punctuation after the trailing dollar sign OR for | |||
| math$head(15) # malformed | |||
| math$protect_math() #error | |||
| ``` | |||
| 4. **use of `$` as currency will still work**, but there is a caveat that mixing | |||
There was a problem hiding this comment.
why the two *?
I'd break this sentence in two. Saying it works, saying "nevertheless, if there's broken math ()..."
| this inline math broken across lines will cause problems: | ||
| ```{r, split, error = TRUE} | ||
| # this will be mal-formed | ||
| bad <- "It's 5:45 and I've got $5.45 in my pocket.\nThe __area of a circle__ is $A =\n \\pi r^2$, where\n$\\pi$ is irrational when it hasn't had its coffee." |
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a catch that will make the
$protect_math()method exit early withoutan error if there is unbalanced math without any trailing dollar signs, which
will indicate text with dollar amounts (like grants).
Note that this is still vulnerable if dollars are mixed with math that is broken
across lines.
This will fix #121