If no yaml, avoid prepending with gratuitous \n
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Thank you! I will admit, when I saw that you had forked the repo, I was kind of excited because "OMG JB noticed!" I've tested this locally with the dev version of glue and can confirm that it works. I'm going to merge. Would you like to be added to the DESCRIPTION as a contributor? I will definitely get this submitted to CRAN if not today then next week by Wednesday. |
No thanks, this is just me fixing a small thing we're going to break 😅
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts tinkr for forward compatibility with glue. I will release glue no sooner than 2 weeks from now, so on March 31 (or likely a bit later).
In the next version of glue,
glue::glue_collapse()will never returncharacter()but instead will return""for empty inputs. For more detail see tidyverse/glue#295.In my hands, this PR makes tinkr work as intended with released glue and dev glue.