Fix #115: Decoding errors #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenator
added
bug
Fix in Review
Handle decoding errors when reading from a serial port. NMEA sentences should be ASCII- encoded, but if malformed data comes in from the serial port, it won't decode properly. If the exception isn't handled, the node will crash. This commonly happens on startup. Also a couple of codestyle fixes. Signed-off-by: Ed Venator <evenator@gmail.com>
evenator
force-pushed
the
fix-115-handle-decoding-errors
branch
from
e278b0b
to
9749351
Compare
donkikos
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
I tested the nmea_serial_driver node after this fix. No crashes as of now.
Used GlobalSat BU-353-S4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle decoding errors when reading from a serial port. NMEA sentences should be ASCII-encoded, but if malformed data comes in from the serial port, it won't decode properly.
If the exception isn't handled, the node will crash. This commonly happens on startup.
When tested with a BU-353S4 receiver, I reproduced the error reported in #115 and now it prints the following warning and does not crash:
Also a couple of codestyle fixes.