Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket driver #32

Merged
merged 17 commits into from
Aug 26, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Add various talker IDs"
This reverts commit 4be9192.
  • Loading branch information
LoyVanBeek committed Aug 18, 2018
commit 02962310adfd08dd98fd17ffc95904c53ba138aa
4 changes: 2 additions & 2 deletions src/libnmea_navsat_driver/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ def convert_deg_to_rads(degs):

def parse_nmea_sentence(nmea_sentence):
# Check for a valid nmea sentence
if not re.match('^\$(GP|GN|GL|GA|II|IN|GB|BD|QZ).*\*[0-9A-Fa-f]{2}$', nmea_sentence):

if not re.match('^\$(GP|GN).*\*[0-9A-Fa-f]{2}$', nmea_sentence):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is a regression, because the parser would no longer support $GL* messages.

logger.debug("Regex didn't match, sentence not valid NMEA? Sentence was: %s"
% repr(nmea_sentence))
return False
Expand Down