Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a regex to split tokens in parser #87

Merged
merged 1 commit into from
Jun 13, 2020
Merged

Conversation

evenator
Copy link
Collaborator

@evenator evenator commented Dec 16, 2019

NMEA uses a * character to delimit the beginning of the regex, so use a regex that matches * and , as the field delimiter.

Fixes #86

@evenator evenator added the bug label Dec 16, 2019
@evenator evenator self-assigned this Dec 16, 2019
@evenator evenator changed the title Use a regex to split tokens in parser (#86) Use a regex to split tokens in parser Dec 16, 2019
@rgov
Copy link
Contributor

rgov commented Jan 16, 2020

Should this also remove the field.strip(',')? If you are splitting on , there will not be any , to strip off.

@evenator
Copy link
Collaborator Author

That's a good point @rgov. I'll remove the strip.

@evenator
Copy link
Collaborator Author

Note to self: This needs a final test and then it's ready to merge.

NMEA uses a * character to delimit the beginning of the regex, so use a regex that matches * and , as the field delimiter.
@evenator
Copy link
Collaborator Author

evenator commented Feb 1, 2020

I've regression-tested this PR. I'm still waiting for confirmation from @NearLinHere that it resolves #86.

@evenator evenator added the Fix in Review A fix has been created. Awaiting original reporter's review. label Feb 1, 2020
@evenator evenator merged commit ad1b080 into master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix in Review A fix has been created. Awaiting original reporter's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't parse alt_std_dev from GST correctly
2 participants