Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added python3 noisereduce #42823

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

rafa-martin
Copy link
Contributor

Please add the following dependency to the rosdep database.

Package name:

  • noisereduce

Package Upstream Source:

Purpose of using this:

Noise reduction in python using spectral gating (speech, bioacoustics, audio, time-domain signals).

Distro packaging links:

Links to Distribution Packages

@rafa-martin rafa-martin requested a review from a team as a code owner September 12, 2024 18:52
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Sep 12, 2024
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one change applied

Standard pip disclaimer: ROS packages that depend on pip keys cannot be released into a ROS distribution. They can only be depended on by from-source builds. Because of this, system packages are highly preferred to pip packages.

rosdep/python.yaml Outdated Show resolved Hide resolved
@sloretz sloretz added the changes requested Maintainers have asked for changes to the pull request label Sep 19, 2024
Co-authored-by: Shane Loretz <shane.loretz@gmail.com>
@audrow audrow dismissed sloretz’s stale review September 25, 2024 15:15

Change has been applied

@audrow audrow merged commit 7de13dd into ros:master Sep 25, 2024
4 checks passed
@rafa-martin rafa-martin deleted the rosdistro/add-python3-noisereduce branch September 26, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants