Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor grammatic changes #2719

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Minor grammatic changes #2719

merged 1 commit into from
Jun 10, 2022

Conversation

daniel-bogusz95
Copy link
Contributor

No description provided.

clalancette
clalancette approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this whole file needs to be reviewed, as we have changed some of our best practices around ament_cmake. But these small improvements to clarity can go in without that.

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Jun 10, 2022
@clalancette clalancette merged commit 964e392 into ros2:rolling Jun 10, 2022
mergify bot pushed a commit that referenced this pull request Jun 10, 2022
@daniel-bogusz95 @mergify
Minor grammatic changes (#2719)
edcf003 
(cherry picked from commit 964e392)
@mergify mergify bot mentioned this pull request Jun 10, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jun 10, 2022
@daniel-bogusz95 @mergify
Minor grammatic changes (#2719)
6e9ab7c 
(cherry picked from commit 964e392)
@mergify mergify bot mentioned this pull request Jun 10, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jun 10, 2022
@daniel-bogusz95 @mergify
Minor grammatic changes (#2719)
1f3a8e1 
(cherry picked from commit 964e392)
@mergify mergify bot mentioned this pull request Jun 10, 2022
Merged
clalancette pushed a commit that referenced this pull request Jun 10, 2022
@mergify @daniel-bogusz95
Minor grammatic changes (#2719) (#2722)
8198e30 
(cherry picked from commit 964e392)

Co-authored-by: daniel-bogusz95 <80654328+daniel-bogusz95@users.noreply.github.com>
clalancette pushed a commit that referenced this pull request Jun 10, 2022
@mergify @daniel-bogusz95
Minor grammatic changes (#2719) (#2723)
3923f27 
(cherry picked from commit 964e392)

Co-authored-by: daniel-bogusz95 <80654328+daniel-bogusz95@users.noreply.github.com>
clalancette pushed a commit that referenced this pull request Jun 10, 2022
@mergify @daniel-bogusz95
Minor grammatic changes (#2719) (#2724)
b5e235a 
(cherry picked from commit 964e392)

Co-authored-by: daniel-bogusz95 <80654328+daniel-bogusz95@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daniel-bogusz95 @clalancette