Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update goal_response_callback for humble #2726

Merged
merged 1 commit into from
Jun 20, 2022
Merged

update goal_response_callback for humble #2726

merged 1 commit into from
Jun 20, 2022

Conversation

0ljik
Copy link
Contributor

@0ljik 0ljik commented Jun 13, 2022

No description provided.

fujitatomoya
fujitatomoya reviewed Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0ljik this looks good to me. could you target this fix against rolling branch? then we can backport this to humble.

@fujitatomoya fujitatomoya mentioned this pull request Jun 15, 2022
Closed
@clalancette clalancette changed the base branch from humble to rolling June 20, 2022 21:15
@clalancette clalancette added the backport-humble backport at reviewers discretion; from rolling to humble label Jun 20, 2022
@clalancette clalancette merged commit 2d01656 into ros2:rolling Jun 20, 2022
@clalancette
Copy link
Contributor

@Mergifyio backport humble

clalancette pushed a commit that referenced this pull request Jun 20, 2022
@0ljik @clalancette
update goal_response_callback for humble (#2726)
9c51e26
@clalancette clalancette mentioned this pull request Jun 20, 2022
Merged
clalancette added a commit that referenced this pull request Jun 20, 2022
@clalancette @0ljik
update goal_response_callback for humble (#2726) (#2743)
7329ec0 
Co-authored-by: 0ljik <oljaktl@gmail.com>
mergify bot pushed a commit that referenced this pull request Jun 20, 2022
@0ljik @mergify
update goal_response_callback for humble (#2726)
8fd0dcc 
(cherry picked from commit 2d01656)
@mergify mergify bot mentioned this pull request Jun 20, 2022
Closed
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2022

backport humble

✅ Backports have been created

@0ljik 0ljik deleted the patch-1 branch July 2, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
backport-humble backport at reviewers discretion; from rolling to humble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0ljik @clalancette @fujitatomoya