Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using spin until future complete in python service tutorial #2731

Merged
merged 1 commit into from
Jun 21, 2022
Merged

using spin until future complete in python service tutorial #2731

merged 1 commit into from
Jun 21, 2022

Conversation

SteveMacenski
Copy link
Contributor

Per #2730

clalancette
clalancette approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but I'm going to wait to merge it until Mergify is back online so we can get automatic backports.

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Jun 20, 2022
@clalancette clalancette merged commit e5bb88f into ros2:rolling Jun 21, 2022
mergify bot pushed a commit that referenced this pull request Jun 21, 2022
@SteveMacenski @mergify
using spin until future complete in python service tutorial (#2731)
b7e4bc0 
(cherry picked from commit e5bb88f)
@mergify mergify bot mentioned this pull request Jun 21, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jun 21, 2022
@SteveMacenski @mergify
using spin until future complete in python service tutorial (#2731)
b672fb1 
(cherry picked from commit e5bb88f)
@mergify mergify bot mentioned this pull request Jun 21, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jun 21, 2022
@SteveMacenski @mergify
using spin until future complete in python service tutorial (#2731)
58d2986 
(cherry picked from commit e5bb88f)
@mergify mergify bot mentioned this pull request Jun 21, 2022
Merged
clalancette pushed a commit that referenced this pull request Jun 21, 2022
@mergify @SteveMacenski
using spin until future complete in python service tutorial (#2731) (#…
82510f6 
…2745)

(cherry picked from commit e5bb88f)

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
clalancette pushed a commit that referenced this pull request Jun 21, 2022
@mergify @SteveMacenski
using spin until future complete in python service tutorial (#2731) (#…
235e4ce 
…2746)

(cherry picked from commit e5bb88f)

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
clalancette pushed a commit that referenced this pull request Jun 21, 2022
@mergify @SteveMacenski
using spin until future complete in python service tutorial (#2731) (#…
5e7c17c 
…2747)

(cherry picked from commit e5bb88f)

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
@clalancette clalancette mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SteveMacenski @clalancette @fujitatomoya