-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note that library name must match package name #2749
Conversation
This tripped me up quite a bit because the runtime error is quite non-intuitive: * https://answers.ros.org/question/318938/rclcppexceptionsrclerror/ * ros2/rosidl#441
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I take back my approval. I left one note inline; once that is fixed, I'm happy to approve (again) and merge.
source/Tutorials/Beginner-Client-Libraries/Custom-ROS2-Interfaces.rst
Outdated
Show resolved
Hide resolved
…ces.rst Co-authored-by: Chris Lalancette <clalancette@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks for the iteration!
@Mergifyio backport rolling foxy galactic |
* Add note that library name must match package name This tripped me up quite a bit because the runtime error is quite non-intuitive: * https://answers.ros.org/question/318938/rclcppexceptionsrclerror/ * ros2/rosidl#441 Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 3b83c8f)
* Add note that library name must match package name This tripped me up quite a bit because the runtime error is quite non-intuitive: * https://answers.ros.org/question/318938/rclcppexceptionsrclerror/ * ros2/rosidl#441 Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 3b83c8f)
* Add note that library name must match package name This tripped me up quite a bit because the runtime error is quite non-intuitive: * https://answers.ros.org/question/318938/rclcppexceptionsrclerror/ * ros2/rosidl#441 Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 3b83c8f)
✅ Backports have been created
|
* Add note that library name must match package name This tripped me up quite a bit because the runtime error is quite non-intuitive: * https://answers.ros.org/question/318938/rclcppexceptionsrclerror/ * ros2/rosidl#441 Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 3b83c8f) Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
* Add note that library name must match package name This tripped me up quite a bit because the runtime error is quite non-intuitive: * https://answers.ros.org/question/318938/rclcppexceptionsrclerror/ * ros2/rosidl#441 Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 3b83c8f) Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
* Add note that library name must match package name This tripped me up quite a bit because the runtime error is quite non-intuitive: * https://answers.ros.org/question/318938/rclcppexceptionsrclerror/ * ros2/rosidl#441 Co-authored-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 3b83c8f) Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
This tripped me up quite a bit because the runtime error is quite non-intuitive: