Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note that library name must match package name #2749

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

mikeferguson
Copy link
Contributor

This tripped me up quite a bit because the runtime error is quite non-intuitive:

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I take back my approval. I left one note inline; once that is fixed, I'm happy to approve (again) and merge.

…ces.rst

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks for the iteration!

@clalancette clalancette merged commit 3b83c8f into ros2:humble Jun 23, 2022
@clalancette
Copy link
Contributor

@Mergifyio backport rolling foxy galactic

mergify bot pushed a commit that referenced this pull request Jun 23, 2022
* Add note that library name must match package name

This tripped me up quite a bit because the runtime error is quite non-intuitive:
 * https://answers.ros.org/question/318938/rclcppexceptionsrclerror/
 * ros2/rosidl#441

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 3b83c8f)
mergify bot pushed a commit that referenced this pull request Jun 23, 2022
* Add note that library name must match package name

This tripped me up quite a bit because the runtime error is quite non-intuitive:
 * https://answers.ros.org/question/318938/rclcppexceptionsrclerror/
 * ros2/rosidl#441

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 3b83c8f)
mergify bot pushed a commit that referenced this pull request Jun 23, 2022
* Add note that library name must match package name

This tripped me up quite a bit because the runtime error is quite non-intuitive:
 * https://answers.ros.org/question/318938/rclcppexceptionsrclerror/
 * ros2/rosidl#441

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 3b83c8f)
@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2022

backport rolling foxy galactic

✅ Backports have been created

clalancette pushed a commit that referenced this pull request Jun 23, 2022
* Add note that library name must match package name

This tripped me up quite a bit because the runtime error is quite non-intuitive:
 * https://answers.ros.org/question/318938/rclcppexceptionsrclerror/
 * ros2/rosidl#441

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 3b83c8f)

Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
clalancette pushed a commit that referenced this pull request Jun 23, 2022
* Add note that library name must match package name

This tripped me up quite a bit because the runtime error is quite non-intuitive:
 * https://answers.ros.org/question/318938/rclcppexceptionsrclerror/
 * ros2/rosidl#441

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 3b83c8f)

Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
clalancette pushed a commit that referenced this pull request Jun 23, 2022
* Add note that library name must match package name

This tripped me up quite a bit because the runtime error is quite non-intuitive:
 * https://answers.ros.org/question/318938/rclcppexceptionsrclerror/
 * ros2/rosidl#441

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 3b83c8f)

Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants