Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to install graphviz for local builds [wrid22] #2826

Merged

Conversation

gavanderhoorn
Copy link
Contributor

As per subject.

This should fix #2824.

#2253 installs this in the Docker image, but local builds don't necessarily use that image.

As I'm not familiar with macOS, I've only included hints for Linux and Windows.

The Windows link was copied/adapted from source/Installation/_Windows-Install-Prerequisites.rst.

Sphinx will complain it can't run 'dot' otherwise.

Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl>
@gavanderhoorn gavanderhoorn changed the title Make sure to install graphviz for local builds Make sure to install graphviz for local builds [wrid22] Jul 6, 2022
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for this!

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Jul 6, 2022
@clalancette clalancette merged commit dfd8830 into ros2:rolling Jul 6, 2022
mergify bot pushed a commit that referenced this pull request Jul 6, 2022
Sphinx will complain it can't run 'dot' otherwise.

Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl>
(cherry picked from commit dfd8830)
mergify bot pushed a commit that referenced this pull request Jul 6, 2022
Sphinx will complain it can't run 'dot' otherwise.

Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl>
(cherry picked from commit dfd8830)
mergify bot pushed a commit that referenced this pull request Jul 6, 2022
Sphinx will complain it can't run 'dot' otherwise.

Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl>
(cherry picked from commit dfd8830)
clalancette pushed a commit that referenced this pull request Jul 6, 2022
Sphinx will complain it can't run 'dot' otherwise.

Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl>
(cherry picked from commit dfd8830)

Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
clalancette pushed a commit that referenced this pull request Jul 6, 2022
Sphinx will complain it can't run 'dot' otherwise.

Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl>
(cherry picked from commit dfd8830)

Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
clalancette pushed a commit that referenced this pull request Jul 6, 2022
Sphinx will complain it can't run 'dot' otherwise.

Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl>
(cherry picked from commit dfd8830)

Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
@gavanderhoorn gavanderhoorn deleted the add_graphviz_dep_build_site_locally branch July 7, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

command 'dot' cannot be run (after initial setup of venv)
2 participants