Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of a bogus explanation of the subscriber member variable. #3563

Merged
merged 1 commit into from
May 9, 2023
Merged

Get rid of a bogus explanation of the subscriber member variable. #3563

merged 1 commit into from
May 9, 2023

Conversation

clalancette
Copy link
Contributor

The explanation is no longer valid.

This should fix #3322

@clalancette
Get rid of a bogus explanation of the subscriber member variable.
77f6333 
The explanation is no longer valid.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette added the backport-iron backport at reviewers discretion; from rolling to iron label May 9, 2023
@clalancette clalancette requested a review from audrow as a code owner May 9, 2023 03:52
@clalancette clalancette mentioned this pull request May 9, 2023
Closed
fujitatomoya
fujitatomoya approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it tried to explain that topic_callback receives std::shared_ptr<rclcpp::SerializedMessage> message, but std_msgs::msg::String, which is already explained above lines. after all, i think that is just fine to delete those lines.

@clalancette clalancette merged commit 09c2be5 into rolling May 9, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/fix-recording-a-bag branch May 9, 2023 19:47
mergify bot pushed a commit that referenced this pull request May 9, 2023
@clalancette @mergify
Get rid of a bogus explanation of the subscriber member variable. (#3563
c31c775 
)

The explanation is no longer valid.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit 09c2be5)
@mergify mergify bot mentioned this pull request May 9, 2023
Merged
clalancette added a commit that referenced this pull request May 9, 2023
@mergify @clalancette
Get rid of a bogus explanation of the subscriber member variable. (#3563
9203689 
) (#3574)

The explanation is no longer valid.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit 09c2be5)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
backport-iron backport at reviewers discretion; from rolling to iron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trouble understanding the wording in Recording a bag from a node (C++)
2 participants
@clalancette @fujitatomoya