Update after testing for Tf2 "Using Time (C++)" and "Time travel (C++)" #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before executing the launch commands.
There was a problem hiding this comment.
@BorisBoutillier thanks for creating PR! i have a few comments, could you check?
source/Tutorials/Intermediate/Tf2/Learning-About-Tf2-And-Time-Cpp.rst
Outdated
Show resolved
Hide resolved
|
@BorisBoutillier can we also incorporate the necessary changes from osrf/ros2_test_cases#1009 and osrf/ros2_test_cases#978 in this PR? |
…d the package when necessary.
BorisBoutillier
changed the title
|
I have added a commit with similar changes for the Time Travel with Tf2 C++ tutorial page, next in the Tf2 tutorial series, as propoosed by @Yadunund |
3 tasks
clalancette
approved these changes
May 11, 2023
clalancette
added
the
backport-iron
BorisBoutillier
deleted the
Update-after-testing-Learning-About-Tf2-And-Time-Cpp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
. Updates code references to match the content create during previous tutorials.
. Add hints to build the package before executing the launch commands.
Found during testing. see (osrf/ros2_test_cases#977) and (osrf/ros2_test_cases#1009)