Fix keystore dir name in Security tutorials #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Yadunund
added
the
backport-iron
3 tasks
clalancette
approved these changes
May 18, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 18, 2023
Signed-off-by: Yadunund <yadunund@openrobotics.org> (cherry picked from commit ee95bb6)
clalancette
pushed a commit
that referenced
this pull request
May 18, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users follow the first turotiral on the security page, their keystore dir will be located at
~/sros2_demo/demo_keystore. However other tutorials reference the location as~/sros2_demo/demo_keys. This PR corrects the latter to address osrf/ros2_test_cases#934.It also adds a line in subsequent tutorials to make sure users have completed the first as a prerequisite. This was not obvious when testing osrf/ros2_test_cases#965