Fix up the Pluginlib tutorial to not be Linux only. #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Prerequisites made it seem like this was a Linux only tutorial, when in reality it works on all of our platforms. Change this, and also do some light editing while we are in here. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
ahcorde
approved these changes
Sep 5, 2023
clalancette
added
the
backport-all
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
The Prerequisites made it seem like this was a Linux only tutorial, when in reality it works on all of our platforms. Change this, and also do some light editing while we are in here. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 192070d)
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
The Prerequisites made it seem like this was a Linux only tutorial, when in reality it works on all of our platforms. Change this, and also do some light editing while we are in here. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 192070d)
clalancette
added a commit
that referenced
this pull request
Sep 5, 2023
The Prerequisites made it seem like this was a Linux only tutorial, when in reality it works on all of our platforms. Change this, and also do some light editing while we are in here. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 192070d) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette
added a commit
that referenced
this pull request
Sep 5, 2023
The Prerequisites made it seem like this was a Linux only tutorial, when in reality it works on all of our platforms. Change this, and also do some light editing while we are in here. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 192070d) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Prerequisites made it seem like this was a Linux only tutorial, when in reality it works on all of our platforms. Change this, and also do some light editing while we are in here.
Fixes #3898