Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _Windows-Install-Prerequisites.rst #3915

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Conversation

RobertoRoos
Copy link
Contributor

@RobertoRoos RobertoRoos commented Sep 13, 2023

With a note about the Python path.

Solves #3914

I would suggest to merge this both for the Humble tag and latest, if possible.

With a note about the Python path
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
@RobertoRoos
Copy link
Contributor Author

Should I squash these commits? Or will that happen during merging?

@clalancette
Copy link
Contributor

Should I squash these commits? Or will that happen during merging?

I'll do it during the merge.

@clalancette clalancette merged commit 7eb42f9 into ros2:humble Sep 20, 2023
3 checks passed
@clalancette
Copy link
Contributor

@Mergifyio backport iron rolling

@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2023

backport iron rolling

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Robert Roos <robert.roos@demcon.com>
(cherry picked from commit 7eb42f9)
mergify bot pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Robert Roos <robert.roos@demcon.com>
(cherry picked from commit 7eb42f9)
clalancette pushed a commit that referenced this pull request Sep 20, 2023
…) (#3932)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Robert Roos <robert.roos@demcon.com>
(cherry picked from commit 7eb42f9)

Co-authored-by: Robert <robert.soor@gmail.com>
clalancette pushed a commit that referenced this pull request Sep 20, 2023
…) (#3933)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: Robert Roos <robert.roos@demcon.com>
(cherry picked from commit 7eb42f9)

Co-authored-by: Robert <robert.soor@gmail.com>
@RobertoRoos RobertoRoos deleted the patch-1 branch November 17, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants