Remove the instructions to install some flake8 plugins by hand. #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll get them from rosdep now. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
tfoote
approved these changes
Sep 28, 2023
audrow
approved these changes
Sep 29, 2023
|
ament/ament_lint#454 has been merged, but I'm going to hold off on merging this until we have a release of that PR into Rolling. |
christophebedard
added a commit
to ros-tooling/setup-ros
that referenced
this pull request
Mar 25, 2024
We can rely on rosdep for: 1. Some flake8 plugins, see: ros2/ros2_documentation#3945 2. libtinyxml2-dev from tinyxml2_vendor Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
christophebedard
added a commit
to ros-tooling/setup-ros
that referenced
this pull request
Mar 26, 2024
We can rely on rosdep for: 1. Some flake8 plugins, see: ros2/ros2_documentation#3945 2. libtinyxml2-dev from tinyxml2_vendor 3. libasio-dev for Fast DDS Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
christophebedard
added a commit
to ros-tooling/setup-ros
that referenced
this pull request
Mar 27, 2024
We can rely on rosdep for: 1. Some flake8 plugins, see: ros2/ros2_documentation#3945 2. libtinyxml2-dev from tinyxml2_vendor 3. libasio-dev for Fast DDS Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll get them from rosdep now.
This should go in along with ament/ament_lint#454 . @tfoote @nuclearsandwich @cottsay FYI