Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Declaration XML: Simplify Lead Part #3954

Merged

Conversation

yashi
Copy link
Contributor

@yashi yashi commented Oct 8, 2023

As a non-English native speaker, the lead part of the sentence was a bit hard to read. This commit simplifies it without (hoping) changing the meaning.

Hope you like it.

As a non-English native speaker, the lead part of the sentence was a
bit hard to read. This commit simplifies it without (hoping) changing
the meaning.

Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a good simplification. Thank you!

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Oct 8, 2023
@clalancette clalancette merged commit f0c5507 into ros2:rolling Oct 8, 2023
3 checks passed
mergify bot pushed a commit that referenced this pull request Oct 8, 2023
As a non-English native speaker, the lead part of the sentence was a
bit hard to read. This commit simplifies it without (hoping) changing
the meaning.

Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
(cherry picked from commit f0c5507)
mergify bot pushed a commit that referenced this pull request Oct 8, 2023
As a non-English native speaker, the lead part of the sentence was a
bit hard to read. This commit simplifies it without (hoping) changing
the meaning.

Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
(cherry picked from commit f0c5507)
clalancette pushed a commit that referenced this pull request Oct 8, 2023
As a non-English native speaker, the lead part of the sentence was a
bit hard to read. This commit simplifies it without (hoping) changing
the meaning.

Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
(cherry picked from commit f0c5507)

Co-authored-by: Yasushi SHOJI <yasushi.shoji@gmail.com>
clalancette pushed a commit that referenced this pull request Oct 8, 2023
As a non-English native speaker, the lead part of the sentence was a
bit hard to read. This commit simplifies it without (hoping) changing
the meaning.

Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
(cherry picked from commit f0c5507)

Co-authored-by: Yasushi SHOJI <yasushi.shoji@gmail.com>
@yashi yashi deleted the plugin-declaration-xml-simplify-lead-part branch October 8, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants