Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rospy] add missing logx_throttle_identical in init.py #65

Conversation

mikaelarguedas
Copy link
Contributor

As these functions are escalated in rospy core: https://github.com/ros/ros_comm/blob/845f74602c7464e08ef5ac6fd9e26c97d0fe42c9/clients/rospy/src/rospy/__init__.py#L61

Without this PR mypy reports errors like this:

error: Module has no attribute "logdebug_throttle_identical"; maybe "logdebug_throttle"?  [attr-defined]

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Copy link
Member

@bonprosoft bonprosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!!

@mikaelarguedas
Copy link
Contributor Author

🎉

The test failures seem unrelated to this change. Does this prevent this from being merged / released ? if so is there anything I can do to help this getting integrated?

Happy end of year!

@bonprosoft
Copy link
Member

I'm terribly sorry for my late response, and thank you very much for your contribution (not only to this repository, but also to genmypy.)

Let me merge this PR, and fix this on the main branch. Thank you!

@bonprosoft bonprosoft merged commit 631a80e into rospypi:master Jan 7, 2024
1 of 3 checks passed
@mikaelarguedas mikaelarguedas deleted the rospy_missing_log_function_escalation branch January 7, 2024 11:30
@mikaelarguedas
Copy link
Contributor Author

No worries, thanks for maintaining these projects!

@mikaelarguedas
Copy link
Contributor Author

Thanks again for integrating this.

Do you know where I can get a notification when a new version with this change gets released ?

@bonprosoft
Copy link
Member

Unfortunately, there is no way to get such notifications.

For the deployment, we do force-push artifacts to gh-pages branch at rospypi/simple.
So you can tell whether the latest release is available by checking the commit date.

If you want to get it through a WebAPI, atom feeds provided by GitHub might be helpful:
https://github.com/rospypi/simple/commits/gh-pages.atom

@mikaelarguedas
Copy link
Contributor Author

Thanks for the response.

The issue is that the package I get from pip still has version numbdr 2021.10.6 and doesn't contain the fix.

$ pip install --extra-index-url https://rospypi.github.io/simple/ ros-stubs-all
Defaulting to user installation because normal site-packages is not writeable
Looking in indexes: https://pypi.org/simple, https://rospypi.github.io/simple/
Collecting ros-stubs-all
  Using cached https://github.com/rospypi/simple/raw/stubs/ros-stubs-all/ros_stubs_all-2021.10.6-py2.py3-none-any.whl (183 kB)
Installing collected packages: ros-stubs-all
Successfully installed ros-stubs-all-2021.10.6
$ pip install -U --extra-index-url https://rospypi.github.io/simple/ ros-stubs-all
Defaulting to user installation because normal site-packages is not writeable
Looking in indexes: https://pypi.org/simple, https://rospypi.github.io/simple/
Requirement already satisfied: ros-stubs-all in ./.local/lib/python3.8/site-packages (2021.10.6)

Do I need to install it differently?

@bonprosoft
Copy link
Member

bonprosoft commented Jan 14, 2024

Thanks for pointing out the issue!

I remembered that I need to create a new tag to update the release index of gh-pages.
I've just pushed the tag https://github.com/rospypi/ros_stubs/releases/tag/20240114 , so hopefully everything is ready in a few minutes. https://github.com/rospypi/ros_stubs/actions/runs/7516756019/job/20462167144

Just FYI:
Actually we have two index urls:

The first one is updated when a tag is created, but the second one is updated everytime the main branch is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants