Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds member data #375

Merged
merged 6 commits into from
Apr 6, 2023
Merged

Adds member data #375

merged 6 commits into from
Apr 6, 2023

Conversation

daniellemaxwell
Copy link
Contributor

@daniellemaxwell daniellemaxwell commented Apr 5, 2023

Scope of changes

Adds MemberList data to the teams page. A hellip character has been added to the Actions column.

A separate story has been created to add a clickable menu item once a user clicks on the hellip and to make it so that it may only be seen by certain users, so that will be handled in a separate PR.

Fixes SC-15398

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

Screenshot 2023-04-05 at 4 45 02 PM

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@daniellemaxwell daniellemaxwell marked this pull request as ready for review April 5, 2023 21:33
{
Header: 'Joined Date',
accessor: (date: any) => {
return formatDate(new Date(date.date_added));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I placed formatDate in the util.ts file the date didn't change.

},
},
{
// TODO: Make actions viewable only to members with owner and admin permission
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be included in a separate PR.

Copy link
Contributor

@masskoder masskoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@daniellemaxwell daniellemaxwell merged commit 4108b1b into main Apr 6, 2023
@daniellemaxwell daniellemaxwell deleted the data branch April 6, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants