Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the defined strong colour instead of using the default #145

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

green7ea
Copy link

In theme definitions, a colour was assigned to strong as seen bellow

(setq nano-color-critical   "#EBCB8B") ;; Aurora / nord 11

Unfortunately, strong didn't use this defined colour but the default instead

:foreground (face-foreground 'nano-face-default)

This commit fixes that by using the strong colour that is defined in themes.

In theme definitions, a colour was assigned to strong as seen bellow

```
(setq nano-color-critical   "#EBCB8B") ;; Aurora / nord 11
```

Unfortunately, strong didn't use this defined colour but the default
instead

```
:foreground (face-foreground 'nano-face-default)
```

This commit fixes that by using the strong colour that is defined in
themes.
@green7ea
Copy link
Author

I noticed this when setting strong to another colour in a custom theme and the function names were the same colour as the normal text. With this change, a custom theme, that overwrites strong has a different function name colour as seen bellow.

image

@rougier
Copy link
Owner

rougier commented Jun 19, 2023

Thanks for the report and the fix!

@rougier rougier merged commit f431fce into rougier:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants