Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GA4 compatibility to Google Analytics connector #45

Merged
merged 24 commits into from
Feb 7, 2023
Merged

Add GA4 compatibility to Google Analytics connector #45

merged 24 commits into from
Feb 7, 2023

Conversation

chris-greening
Copy link
Contributor

Description

Add GA4 compatibility to the Google Analytics connectors to pull data from GA4 using the Analytics Data API

Fixes #44

@chris-greening chris-greening added the enhancement New feature or request label Feb 3, 2023
@chris-greening chris-greening self-assigned this Feb 3, 2023
chris-greening and others added 12 commits February 3, 2023 13:07
@chris-greening
ADD: added environment setup to if __name__
ceb33ca
@chris-greening
FIX: fixed docs and var name to reflect Google Analytics connection
6c3cce4
@chris-greening
ADD: added ga4 flag to connect_to_google_analytics
66308d5
@chris-greening
ADD: added call to BetaAnalyticsDataClient for Data API
50f5f26
@chris-greening
ADD: added _process_universal_analytics_data function
1f461b0
@chris-greening
ADD: added reference to _process_universal_analytics_data
20cb5b1
@chris-greening
ADD: added _process_ga4_data connector
1c12bb9
@chris-greening
ADD: added processing_func ternary op for setting which processor to use
81f3086
@chris-greening
MODIFY: renamed _request_google_analytics_data -> _request_universal_…
f66d7d7 
…analytics_data
@chris-greening
MODIFY: renamed _process_raw_google_analytics_data -> _process_raw_un…
e69852e 
…iversal_analytics_data
@chris-greening
MODIFY: renamed function def to universal analytics
d160edb
@chris-greening
ADD: created utils directory for processing functions and module for …
0db8252 
…universal analytics
@chris-greening
Copy link
Contributor Author

Adding in the GA4 connector is going to essentially be a matter of adding a ga4 Boolean flag to the connector instantiation and then dispatching to either Universal Analytics calls or GA4 calls internally by isinstance checking what authenticated connection are passed into get_google_analytics_data

Since we're dispatching to two different sets of connectors behind the scenes I'm creating a google.utils set of submodules so we can separate our UA and GA4 connectors into separate internal implementations that get called from the central user-facing google_analytics module

@chris-greening chris-greening merged commit 1f61aab into main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chris-greening chris-greening

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GA4 compatibility for the Google Analytics connector
1 participant
@chris-greening