Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing key prop in Filters component #262

Closed
wzulfikar opened this issue Nov 8, 2020 · 1 comment · Fixed by #271
Closed

Missing key prop in Filters component #262

wzulfikar opened this issue Nov 8, 2020 · 1 comment · Fixed by #271
Labels
bug Something isn't working

Comments

@wzulfikar
Copy link

Hi there, should there be a key prop in line 445? Thanks :)

https://github.com/AntlerVC/firetable/blob/75a0f03874c7de69095c13eedb0438e356f3732f/www/src/components/Table/Filters/index.tsx#L444-L446
@notsidney notsidney added the bug Something isn't working label Nov 9, 2020
notsidney added a commit that referenced this issue Nov 9, 2020
@notsidney
Fix missing key prop in Filters component (#262)
aa220e2
@notsidney
Copy link
Contributor

Yes there should. Thank you!

@notsidney notsidney mentioned this issue Nov 23, 2020
Merged
@notsidney notsidney linked a pull request Nov 23, 2020 that will close this issue
v1.2.0: Copy column config from existing table #271
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v1.2.0: Copy column config from existing table rowyio/rowy
2 participants
@wzulfikar @notsidney