Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit functionality for options of single select and multi select fields #1248

Merged
merged 2 commits into from
Jun 10, 2023

Conversation

mnmt7
Copy link
Contributor

@mnmt7 mnmt7 commented May 7, 2023

Solves #1247

@vercel
Copy link

vercel bot commented May 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rowy-os ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 0:50am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rowy-typedoc ⬜️ Ignored (Inspect) May 25, 2023 0:50am

@vercel
Copy link

vercel bot commented May 7, 2023

@mnmt7 is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@harinij
Copy link
Member

harinij commented May 24, 2023

@mnmt7 Thanks for submitting the PR. One quick update - can the UI be updated to also auto-save after an edit and clicked out of the text box? I.e someone should be able to double click on an option, edit it and click out of the cell to have the updated value saved instead of the current option to explicitly click the tick option on the right.
Screenshot 2023-05-24 at 12 19 29 pm

@mnmt7
Copy link
Contributor Author

mnmt7 commented May 25, 2023

@harinij I have added the functionality to auto-save when the user clicks outside the text field.
Right now, the labels are editable when the user single-clicks on them. I just wanted to confirm whether it should be a single-click or double-click. Additionally, since the fields are now auto-saved when the user clicks outside the text field, should I remove the tick option or not?

@harinij
Copy link
Member

harinij commented May 30, 2023

@mnmt7 Thanks, the updates look good as it is, we will get it merged soon.

@shamsmosowi shamsmosowi merged commit 5f5e1a6 into rowyio:develop Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants