fix bug: minimize BuildLogsSnack upon fullscreen
#1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@il3ven is attempting to deploy a commit to the Rowy Team on Vercel. A member of the Team first needs to authorize it. |
|
I think the build popup window (or BuildLogsSnack) should be closed when you click on open in fullscreen. The popup is redundant when you have everything in the fullscreen modal. |
In my opinion the build popup shouldn't be closed because it is useful to open the fullscreen modal again. If the modal is closed to view something else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug. There is no issue for this bug so feel free to reject this PR. I found this behavior while browsing around the app and it seemed like a quick fix. Hence this PR.
Current behavior
When the
BuildLogsSnackis maximized, clicking full screen should minimize the component before opening the modal.bug-build-logs.mp4
New behavior
bug-build-logs-fix.mp4