Enables support of SOCKS proxy at Firefox profile. This method is dep…

…recated due the same is implemented inside fxdriver but i think still used.
roydekleijn · Sep 7, 2013 · 0aa9068 · 0aa9068
1 parent 9d31a2b
commit 0aa9068
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 0 deletions.
diff --git a/dotnet/src/webdriver/Firefox/FirefoxProfile.cs b/dotnet/src/webdriver/Firefox/FirefoxProfile.cs
@@ -223,6 +223,7 @@ public void SetProxyPreferences(Proxy proxy)
                     this.SetManualProxyPreference("ftp", proxy.FtpProxy);
                     this.SetManualProxyPreference("http", proxy.HttpProxy);
                     this.SetManualProxyPreference("ssl", proxy.SslProxy);
+                    this.SetManualProxyPreference("socks", proxy.SocksProxy);
                     if (proxy.NoProxy != null)
                     {
                         this.SetPreference("network.proxy.no_proxies_on", proxy.NoProxy);

diff --git a/java/client/src/org/openqa/selenium/firefox/FirefoxProfile.java b/java/client/src/org/openqa/selenium/firefox/FirefoxProfile.java
@@ -259,6 +259,7 @@ public FirefoxProfile setProxyPreferences(Proxy proxy) {
         setManualProxyPreference("ftp", proxy.getFtpProxy());
         setManualProxyPreference("http", proxy.getHttpProxy());
         setManualProxyPreference("ssl", proxy.getSslProxy());
+        setManualProxyPreference("socks", proxy.getSocksProxy());
         if (proxy.getNoProxy() != null) {
           setPreference("network.proxy.no_proxies_on", proxy.getNoProxy());
         }

diff --git a/py/selenium/webdriver/firefox/firefox_profile.py b/py/selenium/webdriver/firefox/firefox_profile.py
@@ -242,6 +242,7 @@ def set_proxy(self, proxy):
             self._set_manual_proxy_preference("ftp", proxy.ftp_proxy)
             self._set_manual_proxy_preference("http", proxy.http_proxy)
             self._set_manual_proxy_preference("ssl", proxy.ssl_proxy)
+            self._set_manual_proxy_preference("socks", proxy.socks_proxy)
         elif proxy.proxy_type is ProxyType.PAC:
             self.set_preference("network.proxy.autoconfig_url", proxy.proxy_autoconfig_url)
 

diff --git a/rb/lib/selenium/webdriver/firefox/profile.rb b/rb/lib/selenium/webdriver/firefox/profile.rb
@@ -156,6 +156,7 @@ def proxy=(proxy)
             set_manual_proxy_preference "ftp", proxy.ftp
             set_manual_proxy_preference "http", proxy.http
             set_manual_proxy_preference "ssl", proxy.ssl
+            set_manual_proxy_preference "socks", proxy.socks
 
             if proxy.no_proxy
               self["network.proxy.no_proxies_on"] = proxy.no_proxy