Fix bookmark list in home buffer, clean shortcuts

bookmark-all-names returns a list of names, but spacemacs-buffer//insert-file-list expect a list of filenames. Shortcut definitions seems to be a mix of two approaches/commits. Removed the unused bits.
royseto · Jun 12, 2015 · 073c58c · 073c58c
1 parent 24d03a9
commit 073c58c
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/core/core-spacemacs-buffer.el b/core/core-spacemacs-buffer.el
@@ -463,10 +463,8 @@ HPADDING is the horizontal spacing betwee the content line and the frame border.
                  :follow-link "\C-m")
   (insert "\n\n"))
 
-(defun spacemacs-buffer//insert-file-list (list-display-name list shortcut-char)
+(defun spacemacs-buffer//insert-file-list (list-display-name list)
   (when (car list)
-    (spacemacs//insert--shortcut "r" "Recent Files:")
-    (spacemacs//insert--shortcut "p" "Projects:")
     (insert list-display-name)
     (mapc (lambda (el)
             (insert "\n    ")
@@ -492,15 +490,18 @@ HPADDING is the horizontal spacing betwee the content line and the frame border.
               (cond
                ((eq el 'recents)
                 (recentf-mode)
-                (when (spacemacs-buffer//insert-file-list "Recent Files:" (recentf-elements 5) "r")
+                (when (spacemacs-buffer//insert-file-list "Recent Files:" (recentf-elements 5))
+                  (spacemacs//insert--shortcut "r" "Recent Files:")
                   (insert list-separator)))
                ((eq el 'bookmarks)
                 (helm-mode)
-                (when (spacemacs-buffer//insert-file-list "Bookmarks:" (bookmark-all-names) "b")
+                (when (spacemacs-buffer//insert-file-list "Bookmarks:" (mapcar 'bookmark-get-filename (bookmark-all-names)))
+                  (spacemacs//insert--shortcut "m" "Bookmarks:")
                   (insert list-separator)))
                ((eq el 'projects)
                 (projectile-mode)
-                (when (spacemacs-buffer//insert-file-list "Projects:" (projectile-relevant-known-projects) "p")
+                (when (spacemacs-buffer//insert-file-list "Projects:" (projectile-relevant-known-projects))
+                  (spacemacs//insert--shortcut "p" "Projects:")
                   (insert list-separator))))) dotspacemacs-startup-lists))))
 
 (defun spacemacs-buffer/goto-link-line ()