if rpmtdGetUint32 return NULL, return RPMRC_FAIL #1638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While the overall idea of checking the return of the DB query for the priority is the right one this patch has several issues. I'll try to come up with something along the same lines that avoid the issues (returing without freeing resources, breaking the transaction, using fprint instead of rpmlog, ...) |
ffesti
added a commit
to ffesti/rpm
that referenced
this pull request
Aug 24, 2021
|
Replaced by #1763, but thanks for the patch nevertheless. |
mikhailnov
pushed a commit
to mikhailnov/rpm
that referenced
this pull request
Sep 30, 2021
dmnks
pushed a commit
to dmnks/rpm
that referenced
this pull request
Jun 7, 2022
Resolves: rpm-software-management#1636 Related: rpm-software-management#1638 (cherry picked from commit fd57fc7)
dmnks
pushed a commit
to dmnks/rpm
that referenced
this pull request
Jun 7, 2022
Resolves: rpm-software-management#1636 Related: rpm-software-management#1638 (cherry picked from commit fd57fc7)
dmnks
pushed a commit
to dmnks/rpm
that referenced
this pull request
Jun 7, 2022
Resolves: rpm-software-management#1636 Related: rpm-software-management#1638 (cherry picked from commit fd57fc7)
dmnks
pushed a commit
to dmnks/rpm
that referenced
this pull request
Jun 8, 2022
Resolves: rpm-software-management#1636 Related: rpm-software-management#1638 (cherry picked from commit fd57fc7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1636