Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prepend and append modes for all our normal build scriptlets #2728

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

pmatilai
Copy link
Member

Allows %build, %install, %check, %clean and %generate_depends to be augmented arbitrary number of times by appending or prepending to them. The main use-case is to support automatic population of these sections (declarative builds) while still allowing packagers to easily tweak them, but could also be useful for complicated conditional specs and such.

%prep is missing from the list because it's way too special at the moment, it'll gain this capability when #2205 is fixed.

Related: #1087

@pmatilai pmatilai added RFE handsfree Packaging automation and convenience labels Oct 20, 2023
docs/manual/spec.md Outdated Show resolved Hide resolved
docs/manual/spec.md Outdated Show resolved Hide resolved
tests/data/SPECS/append.spec Outdated Show resolved Hide resolved
@pmatilai
Copy link
Member Author

Once #2730 is merged we get to drop the %prep exception from this.

@ffesti
Copy link
Contributor

ffesti commented Oct 26, 2023

May be people like this version better.

Allows %prep, %conf, %build, %install, %check, %clean and %generate_depends
to be augmented arbitrary number of times by appending or prepending to
them. The main use-case is to support automatic population of these
sections (declarative builds) while still allowing packagers to easily
tweak them, but could also be useful for complicated conditional specs
and such.

Related: rpm-software-management#1087
@pmatilai
Copy link
Member Author

Thanks @ffesti, but I ended up rewriting that from scratch now that the %prep exception is gone. It still isn't a great piece of literature exactly but hopefully passable for a reference manual now.

@pmatilai pmatilai merged commit 283935b into rpm-software-management:master Oct 27, 2023
1 check passed
@pmatilai pmatilai deleted the append-pr branch October 27, 2023 08:07
@pmatilai pmatilai added the highlight Release highlight label Feb 21, 2024
@dmnks dmnks added the packaging Package building, SPEC files, etc. label Mar 22, 2024
@dmnks dmnks changed the title Implement prepend and append modes for all our normal build scriptlets Add prepend and append modes for all our normal build scriptlets Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
handsfree Packaging automation and convenience highlight Release highlight packaging Package building, SPEC files, etc. RFE
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants