Spring cleaning! #2977
Merged
Spring cleaning! #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These things are not really returning rpmRC values, especially as they need to pass around RPMRC_MISSINGBUILDREQUIRES which is not part of the enum. For doRmSource(), 0 and 1 aren't any more enums values than 0 and -1 are, and besides, the sole caller isn't even checking the return code.
-1 is not a valid rpmCompressedMagic. As this code is only interested in whether the file checks as COMPRESSED_NOT, any legit value that differs from that is fine for the purpose. No functional changes.
Enums are good for individual bitfield flag names, but combination of the bits is not a legit value really.
It's legit C99 but it's rare and weird.
rpmfiDigestAlgo() can return 0 for errors in which case we have no business trying to sign the thing, and crazily rpmfiDigestAlgo() returns a signed int so there's that too...
I guess somebody somewhen a long long time ago thought this would make it go that little bit faster. It doesn't.
This returns a tag value, not type.
The sentinel in the tag extension table is not an rpmTag enum
rpmfiDigestAlgo() hysterically returns a signed int (and that's what really ought to be changed) but lets at least make all these uses consistent.
For once, we get to use a restrictive type for something...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Int vs enum type mismatches, initialization order consistency and other "fascinating" trivia.