Enable C++ exceptions on the codebase #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jan Engelheart pointed out that with -fno-exceptions `new` failing will return a nullptr. Which seems fine until you realize that all of rpm is built on the notion that allocations never fail, they terminate the program instead. Only with the C++ refactorings, a significant portion of the code is now relying on `new` and not checking its return. Ooops. Uncaught exceptions will terminate an unsuspecting program anyhow, let that happen. We'll be adding catches over time... Besides allocations, not being able to deal with exceptions in the C++ side of things would put us at severe handicap all over the place - they are an essential part of the language and STL.
Conan-Kudo
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jan Engelheart pointed out that with -fno-exceptions
newfailing will return a nullptr. Which seems fine until you realize that all of rpm is built on the notion that allocations never fail, they terminate the program instead. Only with the C++ refactorings, a significant portion of the code is now relying onnewand not checking its return. Ooops.Uncaught exceptions will terminate an unsuspecting program anyhow, let that happen. We'll be adding catches over time...
Besides allocations, not being able to deal with exceptions in the C++ side of things would put us at severe handicap all over the place - they are an essential part of the language and STL.