Default to test-suite disabled in cmake #3391
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite being bound to "make check" and reasonably fast, our tests sit at least one level above what you'd normally call "self tests" or "unit tests" and require external container tooling to run. Therefore, disable them by default, they're only really useful for RPM development, certainly not for building RPM itself, e.g. from a release tarball. Update INSTALL and Dockerfile accordingly. Fixes: rpm-software-management#3388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite being bound to "make check" and reasonably fast, our tests sit at least one level above what you'd normally call "self tests" or "unit tests" and require external container tooling to run.
Therefore, disable them by default, they're only really useful for RPM development, certainly not for building RPM itself, e.g. from a release tarball. Update the INSTALL file accordigly.
Fixes: #3388