Fix false positive for UnsafeToAtom

Refs #1148
rrrene · Sep 22, 2024 · 5af2172 · 5af2172
1 parent 1deaa53
commit 5af2172
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/credo/check/warning/unsafe_to_atom.ex b/lib/credo/check/warning/unsafe_to_atom.ex
@@ -48,6 +48,10 @@ defmodule Credo.Check.Warning.UnsafeToAtom do
     {nil, issues}
   end
 
+  defp traverse({:unquote, _, [_ | _] = _args}, issues, _) do
+    {nil, issues}
+  end
+
   defp traverse(
          {:|>, _meta1, [_lhs, {{:., _meta2, call}, meta, args}]} = ast,
          issues,

diff --git a/test/credo/check/warning/unsafe_to_atom_test.exs b/test/credo/check/warning/unsafe_to_atom_test.exs
@@ -8,7 +8,7 @@ defmodule Credo.Check.Warning.UnsafeToAtomTest do
   #
 
   test "it should NOT report expected code" do
-    """
+    ~S"""
     defmodule CredoSampleModule do
       @test_module_attribute String.to_atom("foo")
       @test_module_attribute2 Jason.decode("", keys: :atoms)
@@ -36,6 +36,10 @@ defmodule Credo.Check.Warning.UnsafeToAtomTest do
       def convert_erlang_binary(parameter) do
         :erlang.binary_to_existing_atom(parameter, :utf8)
       end
+
+      for n <- 1..4 do
+        def unquote(:"fun_#{n}")(), do: unquote(n)
+      end
     end
     """
     |> to_source_file()