Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get ast node #88

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

Conversation

sgharms
Copy link

@sgharms sgharms commented Apr 14, 2017

Per lukehoban/es6features#107, the getASTNode() confuses learning. Provide a concrete Object.

Steven G. Harms added 2 commits April 14, 2017 12:40
It's not entirely claer what getASTNode() returns.
Is this a single node? Many unfamiliar with ASTs
might assume that it's an `{op: ..., lhs: ...,
rhs: ...}` which maps to this example, but in the
subsequent exaple the node contains another node
which isn't immediately evident and which makes
the example more complex to grasp.
It's not entirely claer what getASTNode() returns.
Is this a single node? Earlier examples introduce
that AST nodes are `{op: ..., lhs: ...,
rhs: ...}` which doesn't conform to this example
(where there is nesting). Be explicit.
@rse
Copy link
Owner

rse commented Dec 20, 2017

You are using ES6 fat arrow operators in the ES5 code snippets. This cannot be right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants