-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oddsare init #1
base: master
Are you sure you want to change the base?
oddsare init #1
Conversation
*/ | ||
|
||
project.ext.react = [ | ||
entryFile: "artifacts/index.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited this to redirect entrypoint to Typescript output.
|
||
@Override | ||
protected String getJSMainModuleName() { | ||
return "artifacts/index"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited directly for Typescript output
{ | ||
NSURL *jsCodeLocation; | ||
|
||
jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"artifacts/index" fallbackResource:nil]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited directly for typescript output
7a6f985
to
71af841
Compare
@rsetaluri did you want to TAL before we merge? |
You're good to merge. |
nit: prefer LGTM or approval of PR |
LGTM |
raj lbtm |
that's what they all say |
If I've said it once, I've said it 1000 times. |
PTAL: @atran3 @rsetaluri
Tried to remember to put most of the setup steps in the README but wouldn't be surprised if I forgot something.
Also copied most of the .gitignore from somewhere so the random android/ios files I think we are supposed to check in (also edited a few of them directly - notes inline).
Android/ios emulators: https://cl.ly/1v0v401w0Q2r