-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preload bug jquery 3.0 #20
Comments
Thanks for the patch! Would be good to see it merged - perhaps you should change the above to a pull request? |
IdanAdar
added a commit
to MobileFirst-Platform-Developer-Center/DevCenter
that referenced
this issue
Oct 31, 2016
The gifplayer plug-in stopped working once we’ve started using jQuery 3.x. Looks like this happens due to a change in the way `load` works, which is used in the gifplayer plugin. See here: rubentd/gifplayer#20 Signed-off-by: Idan Adar <iadar@il.ibm.com>
mattrabe
added a commit
to mattrabe/gifplayer
that referenced
this issue
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Found this little bug using jquery 3.0. According to the answer on Stackoverflow the preload "load" function needs to be different:
http://stackoverflow.com/questions/37738732/jquery-3-0-url-indexof-error
So when changing:
// Wait until gif loads this.gifElement.load( function(){ gp.animationLoaded = true; gp.resetEvents(); gp.previewElement.hide(); gp.wrapper.append(gp.gifElement); gp.spinnerElement.hide(); gp.getOption('onLoadComplete').call(gp.previewElement); });
to
// Wait until gif loads this.gifElement.on({ load: function(){ gp.animationLoaded = true; gp.resetEvents(); gp.previewElement.hide(); gp.wrapper.append(gp.gifElement); gp.spinnerElement.hide(); gp.getOption('onLoadComplete').call(gp.previewElement); } });
Things work again.
Thanks for this plugin!
Greetz,
walter
The text was updated successfully, but these errors were encountered: