Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't autocorrect BigDecimal with float when precision is specified #150

Merged
merged 1 commit into from
Jul 11, 2020

Conversation

eugeneius
Copy link
Contributor

The precision argument to BigDecimal() is ignored unless the value is a float or rational. Converting the value from a float to a string when a precision is specified changes the result.

$ ruby -rbigdecimal -e "puts BigDecimal(3.14, 1)"
0.3e1

$ ruby -rbigdecimal -e "puts BigDecimal('3.14', 1)"
0.314e1

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Can you rebase with the latest master branch?

The precision argument to `BigDecimal()` is ignored unless the value is
a float or rational. Converting the value from a float to a string when
a precision is specified changes the result.

    $ ruby -rbigdecimal -e "puts BigDecimal(3.14, 1)"
    0.3e1

    $ ruby -rbigdecimal -e "puts BigDecimal('3.14', 1)"
    0.314e1
@eugeneius
Copy link
Contributor Author

Rebased ✅

@koic koic merged commit 3c83bf5 into rubocop:master Jul 11, 2020
@koic
Copy link
Member

koic commented Jul 11, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants