Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves longer running operations causing timeouts - #216 #636

Merged
merged 13 commits into from
Jun 18, 2020
Merged

Conversation

jaapbrasser
Copy link
Contributor

Description

Syncronis commands that run/wait longer than 15 seconds should complete successfully. A variable to change the timeout length should be available.

Related Issue

Resolves #216

Motivation and Context

Solves timeouts with longer running commands, using the new Set-RubrikModuleOption cmdlet to facilitate this

How Has This Been Tested?

Tested the new timeouts against web endpoint with customizable timeouts

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mwpreston mwpreston self-requested a review June 8, 2020 13:52
Copy link
Contributor

@mwpreston mwpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see more use of the ModuleOptions

Thanks @jaapbrasser

@mwpreston mwpreston merged commit fc17804 into devel Jun 18, 2020
@jaapbrasser jaapbrasser deleted the jaap-216 branch July 16, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Longer running operations cause timeout
2 participants