Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unicode issues with cmdlets #769

Merged
merged 24 commits into from
Jul 6, 2021
Merged

Fixed unicode issues with cmdlets #769

merged 24 commits into from
Jul 6, 2021

Conversation

jaapbrasser
Copy link
Contributor

@jaapbrasser jaapbrasser commented Jul 4, 2021

Description

Fix Regional / unicode encoding issues

Related Issue

Resolves #770
Resolves #768
Resolves #766
Resolves #750
Resolves #749
Resolves #721

Motivation and Context

Regional / unicode encoding issues

How Has This Been Tested?

Current unit tests run, new unit tests have been created

Screenshots (if appropriate):

image

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@mwpreston mwpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks great to me :)

@mwpreston mwpreston merged commit 986651a into devel Jul 6, 2021
@jaapbrasser jaapbrasser deleted the jaap-unicode branch July 16, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment