Implement pending past court date model specs #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Continuation of #2095
What changed, and why?
In #2095, @compwron asked me to implement some pending tests for the PastCourtDate model, so this is the main reason for this pull request.
What I did was:
spec/models/past_court_date.rbtospec/models/past_court_date_spec.rb#associated_reportsmethod and the#latest_associated_reportmethod in the PastCourtDate model specRails.root.joinnotationHow will this affect user permissions?
No permissions have been changed.
How is this tested? (please write tests!) 💖💪
Improved PastCourtDate model specs.
Screenshots please :)
Screenshots are not applicable, since this basically only changed the specs.