doc: added deletion overview with very high level chart. #288 #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bari12
requested changes
Apr 9, 2024
website/static/img/Repear-repear.png
Outdated
There was a problem hiding this comment.
This is not correct.
OBSOLETE replicas are ALWAYS removed, greedy or not.
The replicas which are removed (in both branches) are the ones with a tombstone.
There was a problem hiding this comment.
Also please change repear-repear to Reaper
|
All the comments has been resolved !! |
voetberg
reviewed
Aug 12, 2024
There was a problem hiding this comment.
Can you make the bottom left box a little larger? The a., b., c., tangent-ing with the box edge makes it harder to read.
voetberg
reviewed
Aug 12, 2024
website/static/img/Repear-repear.png
Outdated
There was a problem hiding this comment.
Spelling: obsolete not obsolote, and Reaper not repear (see Martin's above comment). The two triangle boxes should be enlarged to make sure the text doesn't escape them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the deletion overveiw in different chapter.
Few things I am not clear.
When setting TOMBSTONE by cleaner and undertaker , what is the value it sets. I look through the code and not clear to me.
The chart are very crude and may need some imporvement suggestion needed here.