Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core,desktop: Update to winit v0.30.5 and latest egui from git #17401

Merged
merged 1 commit into from
Sep 11, 2024
Merged

core,desktop: Update to winit v0.30.5 and latest egui from git #17401

merged 1 commit into from
Sep 11, 2024

Conversation

torokati44
Copy link
Member

@torokati44 torokati44 commented Aug 7, 2024 •
edited
Loading

Still needs some cleanup and porting and migrating away from deprecated stuff to the new and shiny new trait-based APIs I think.

Not latest minor version, because:
emilk/egui#4849 (comment)

But soon it probably can be:
rust-windowing/winit#3849

Supersedes #16835.

@torokati44
Copy link
Member Author

torokati44 commented Aug 9, 2024 •
edited
Loading

Soon we can (hopefully) bump to 0.30.5: emilk/egui#4939
Also, this may fix the touch interactivity problems on Steam Deck? 👀 Never mind, that was about scaling, not touch input... #14053

EDIT: Now on winit v0.30.5.

@torokati44 torokati44 changed the title core,desktop: Update to winit v0.30.2 and latest egui from git core,desktop: Update to winit v0.30.5 and latest egui from git Aug 9, 2024
@torokati44 torokati44 force-pushed the winit-0.30 branch 2 times, most recently from cbd2b82 to 5430378 Compare August 22, 2024 20:56
@torokati44 torokati44 marked this pull request as ready for review August 22, 2024 21:29
@torokati44
Copy link
Member Author

Right now, this is a mechanical, "just the minimum to get it working" port, with two #[allow(deprecated)] lines added.
To get rid of those, a significant refactor to app.rs will have to be done.
There's also a minor change in behavior wrt. max_window_size, but I don't think it can be problematic really.

@torokati44 torokati44 mentioned this pull request Aug 26, 2024
Closed
@torokati44 torokati44 added the waiting-on-review Waiting on review from a Ruffle team member label Aug 26, 2024
@torokati44 torokati44 mentioned this pull request Aug 26, 2024
Closed
@torokati44 torokati44 force-pushed the winit-0.30 branch 2 times, most recently from 4dd9d1e to 6322560 Compare August 27, 2024 16:04
@torokati44 torokati44 added A-desktop Area: Desktop Application A-deps Area: Dependencies labels Aug 27, 2024
@torokati44
Copy link
Member Author

torokati44 commented Aug 28, 2024 •
edited
Loading

After this is merged, update dependencies to include these:

@torokati44 torokati44 force-pushed the winit-0.30 branch 2 times, most recently from 1ad68dd to fdd1147 Compare September 11, 2024 10:02
@torokati44
Copy link
Member Author

Thank you for the approval, @sleepycatcoding!
I've just now added a TODO comment to both of the allow(deprecated) attributes, and bumped egui to the current latest master, which necessitated following an API change: emilk/egui#5025

I hope these don't invalidate your approval. :)

@torokati44 torokati44 merged commit 490c02b into ruffle-rs:master Sep 11, 2024
16 of 17 checks passed
@sleepycatcoding sleepycatcoding removed the waiting-on-review Waiting on review from a Ruffle team member label Sep 11, 2024
@kjarosh kjarosh mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaron1011 Aaron1011 Aaron1011 approved these changes

@sleepycatcoding sleepycatcoding sleepycatcoding approved these changes

Assignees
No one assigned
Labels
A-deps Area: Dependencies A-desktop Area: Desktop Application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torokati44 @Aaron1011 @sleepycatcoding